fs_storage_path_prefix excluded in the migration on postgresql, but added via db:add-missing-indices
Open
Nobody has claimed this yet.
1. to develop
28-feedback
bug
feature: filesystem
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Did a fresh installation on PostgreSQL 16 and was greeted with:
Migration:
Add missing index:
- The initial version had the check for pqsql: https://github.com/nextcloud/server/pull/28541
- It got lost in a bigger refactoring: https://github.com/nextcloud/server/pull/39487
@icewind1991 what would you recommend, is there something to do?
cc @nextcloud/server-backend
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the PostgreSQL handling in core/Migrations/Version13000Date20170718121200.php around lines 241-243 with core/Application.php around lines 93-98. Read the referenced pull requests #28541 and #39487 to understand how the condition changed. Done means a fresh PostgreSQL installation handles fs_storage_path_prefix consistently between migration and db:add-missing-indices.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, postgresql
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100