Invalid "login_credentials" with passwordless login
Open
Nobody has claimed this yet.
0. Needs triage
feature: authentication
technical debt
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Steps to reproduce:
- Login with a webauthn device
IStore.getLoginCredentialsreturns an array with a username and an empty password.
Technical debt
Code using getLoginCredentials has to check for null or empty string and also a couple of exceptions^1.
Better: throw PasswordUnavailableException and have a clear way to signal a passwordless login.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing IStore.getLoginCredentials and the caller referenced in lib/Controller/PageController.php at lines 180-181, then review the related issue about passwordless login. Done means passwordless authentication has a clear PasswordUnavailableException signal and callers no longer need null, empty-string, or special-case checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100