Unify "Hide download" for public share and "Allow download" behavior for user share + provide possibility to configure it
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
I've just realized that there is some inconsistency between sharing for concrete user and public link.
:mag: Public share has "Hide download" checkbox
:mag: At the same time sharing for concrete user has inversed logic "Allow download"
It would be nice to unify behavior and provide same experience for both public and user shares for better consistency.
Also there is possibility to change default permission for a new share. But there is no way to disable download for new shared. Can we add this option?
Related to #45412.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by tracing the public-share and user-share controls described in the screenshots, then inspect related issue #45412 and the existing default-permission setting. Done means both share types present consistent download behavior and a configurable default is available for new shares.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- authorization, full-stack
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100