Address book / CardDAV federation: User account deletion not considered
Open
Nobody has claimed this yet.
0. Needs triage
27-feedback
28-feedback
29-feedback
30-feedback
bug
feature: carddav
feature: federation
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Steps to reproduce
- Set up CardDAV federation for Nextcloud A and Nextcloud B
- A&B: Run
dav:sync-system-addressbookandfederation:sync-addressbooks - Check via contacts or thunderbird that we have a copy of the remote address book
- B: Add a new user bob
- A&B: Run
dav:sync-system-addressbookandfederation:sync-addressbooks - A: Check that bob from B is there
- B: Delete bob
- A&B: Run
dav:sync-system-addressbookandfederation:sync-addressbooks - A: Bob's still there
getChangesForAddressBookdoes include the deleted user- The deleted element is not processed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in apps/dav/lib/CardDAV/SystemAddressbook.php, especially getChangesForAddressBook and the deleted-element processing described in the issue. Reproduce the sequence with dav:sync-system-addressbook and federation:sync-addressbooks across two Nextcloud instances. Done means a user deleted on B is removed from A's federated address book after synchronization.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100