Add opcache validate/re-validate setupCheck (or warning in Updater)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Inform operator if restarting mod_php/fpm is more likely than not to be needed after triggering an Upgrade so people are less surprised when this happens and/or to remind people that adjust these values but then later forget. :)
Options:
- An info level message in existing PhpOpcacheSetup setupcheck
- Something within
updatenotificationapp that gets displayed on the Updater screen - Something in Updater itself
Or:
- Just tell people to restart always 🤷♂️
Currently going to focus on clarifying in the documentation: nextcloud/documentation#11872
Related:
- #45490, #45504, among others (forum posts too)
- #39079
- https://core.trac.wordpress.org/ticket/36455 (much bigger topic; we could make some things better with some changes with how we handle both Server and app upgrades, but there's no foolproof solution)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing PhpOpcacheSetup setupcheck and the Updater and updatenotification areas mentioned in the issue. Compare the proposed warning locations with the clarified documentation in nextcloud/documentation#11872; the work is complete when operators are reliably informed whether restarting mod_php or fpm may be needed after an upgrade.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100