nextcloud / nextcloud/server

[Bug]: Deleting multiple big folders results in possibly missing folders from trash bin

Open
#44,414 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 27-feedback bug feature: trashbin
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

Deleting at the same time multiple big folders (with many files inside) may result in missing folders in trashbin.

Steps to reproduce
  1. Create folder1, folder2 and folder3
  2. Add 10 000 files inside each folder (for i in {1..10000}; do touch test${i}.txt; done)
  3. Delete the 3 folders
  4. Check what is in the trashbin
Expected behavior

folder1, folder2 and folder3 visible in trashbin

Installation method

None

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with three folders containing 10,000 files each, using the shell loop described in the report, then inspect the trashbin after concurrent deletion. The fix is complete when folder1, folder2, and folder3 all remain visible in the trashbin; the issue does not name a source file or test to begin with.

Written by the indexing model from the issue text.

Assessment

Tech stack
apache, mariadb, php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.