nextcloud / nextcloud/server

[RFC] Sharing status indicator

Open
#43,443 7 comments 0 reactions 1 assignee View on GitHub

@skjnldsv is already working on this.

Since Mar 15, 2024.

1. to develop design enhancement feature: files feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Hi @nextcloud/designers, we've had a few changes on the sharing status indicator and I've seen various changes requests or small sentences here and there that lead me to ask what you have in mind really.

Gathering data

From https://github.com/nextcloud/server/issues/41620
Current Medium with avatars + icons Remove label for shares from others
Sharing current sharing medium Sharing plain

@jancborchardt said
We discussed it with @nextcloud/designers and will go with the middle option as that is a good middle ground between the 2, and it takes into account Clémentine’s feedback from user testing.

From https://github.com/nextcloud/server/pull/41656

@marcoambrosini said
For what is worth, I also think it's better to always show the shared label at all times. I think it's the 2nd most important thing after the file name. Let's figure out a better strategy to make things clear soon!

Other references:

Current implementation

If I share a file, even multiple times with different shares, we use the following logic (was like that in old times too)

Share type Icon
link or email 🔗
group or federated group 👩‍👧‍👦
circles
not shared ⁺🧑

Final request

As far as I understood and this is where I need confirmation from you :)

Owner Shared with Result
mine none image
mine link or email image
mine group or federated group image
mine user image
someone else none image
someone else link or mail image
(you get the point for the Shared with icons) any owner-avatar + matching type icon that will be primary

⚠️ If we have multiple shares, we use the logic mentioned above: mail/link, then group/federated group, then circles and finally user

It seems to be what I understood, please confirm so I can fix the code made in a hurry for 28! 🙏

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.