Set authtoken.private_key and authtoken.public_key NULL for auth.storeCryptedPassword=true
@juliusknorr is already working on this.
Since Feb 8, 2024.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
As a Nextcloud admin I might not need my users to authenticate on external storage or use provisioned accounts in Mail, nor do I need automatic logouts after password changes.
In that case, the password in authtoken is not used. Maintaining it is an overhead. The private and public keys have a combined size of ~6kB. This makes INSERT, UPDATE and DELETE heavier. Replication has to transport more data too.
Describe the solution you'd like
If auth.storeCryptedPassword is set to true, do not generate a keypair. Leave private_key, public_key and password NULL.
Describe alternatives you've considered
N/a
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.