nextcloud / nextcloud/server

[Bug]: Redundant index oc_mounts.mounts_storage_index

Open
#43,106 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 29-feedback 30-feedback bug feature: database feature: external storage performance 🚀
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description
create index mount_user_storage
    on nextclouddev.oc_mounts (storage_id, user_id);

create index mounts_storage_index
    on nextclouddev.oc_mounts (storage_id);

The duplicate index makes all INSERT and DELETE queries more expensive.
Should we have UPDATEs for storage_id, those are more expensive too.

Steps to reproduce
  1. Install Nextcloud
Expected behavior

Efficient use of database indices

Installation method

None

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Nextcloud database schema or migration definitions for oc_mounts and the mount_user_storage and mounts_storage_index indexes. Compare the indexes created by a fresh installation, then verify that the redundant single-column index is removed without losing required lookup coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, sql
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.