nextcloud / nextcloud/server

[Bug]: Version checker show current version after update in web GUI

Open
#42,197 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 25-feedback bug feature: caching feature: install and update
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

Noticed on update from 25.0.10.2 => 25.0.13.3 and 25.0.13.3 => 25.0.13.4 (latest patch version atm)

updater.log file shows correct version to update to (next major, 26.0.9.2)

image

Thoughts after research:

  • Opcache might cache old php version and use it for the request - in this case seems to be configured correctly, so shouldn't be the reason;
  • Value for web-interface is cached for 30 minutes maximum if check is called, but there might be something that prevents it from refresh.

Code sources:
updater - version check:
https://github.com/nextcloud/updater/blob/master/lib/Updater.php#L126

admin page - vesion check:
https://github.com/nextcloud/server/blob/master/lib/private/Updater/VersionCheck.php#L52

Issue posted to track it, as may happens sometime on more recent versions (27.1.4.1)

Steps to reproduce
  1. Perform update via updater.phar
  2. Check admin page to see if that happens
Expected behavior

Web GUI should show correct version to update to (next major, 26.0.9.2 in that case)

Installation method

Official All-in-One appliance

Nextcloud Server version

26

Operating system

None

PHP engine version

PHP 8.0

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

updater.log:

2023-11-29T14:01:55+0000 <request> [info] releaseChannel: enterprise
2023-11-29T14:01:55+0000 <request> [info] internal version: 25.0.13.4
2023-11-29T14:01:55+0000 <request> [info] updateURL: https://updates.nextcloud.com/customers/<subsciption-key>/?version=25x0x13x4xxxenterprisexx2023-11-23<hash>
2023-11-29T14:01:55+0000 <request> [info] getUpdateServerResponse response: Array
(
    [version] => 26.0.9.2
    [versionstring] => Nextcloud 26.0.9 Enterprise
    [url] => https://download.nextcloud.com/.customers/server/26.0.9-102bdc0d/nextcloud-26.0.9-enterprise.zip
    [web] => https://docs.nextcloud.com/server/26/admin_manual/maintenance/upgrade.html
    [changes] => https://updates.nextcloud.com/changelog_server/?version=26.0.9
    [autoupdater] => 1
    [eol] => 0
    [signature] => <signature>
)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the version-check paths named in lib/Updater.php around line 126 and lib/private/Updater/VersionCheck.php around line 52. Reproduce an update with updater.phar, compare updater.log with the admin page's displayed version, and trace why the web GUI remains stale. Done means the GUI shows the correct next version after an update.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.