nextcloud / nextcloud/server

Adjustable duration of expiration of VerificationToken

Open
#42,107 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: authentication feature: users and groups
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
When invoking the $this->verificationToken->create() method, it consistently sets the expiration for 7 days. However, there is a requirement to configure the token expiry for a different duration, such as 1 day.

Describe the solution you'd like
We can pass expiry time as argument of create() method here

Describe alternatives you've considered

  • N/A

Additional context
We have a requirement to set token expiration at specific intervals, like 15 minutes or 1 day. To address this, I am suggesting an enhancement.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lib/public/Security/VerificationToken/IVerificationToken.php at the create() method referenced in the issue. Trace the corresponding verification-token implementation and callers, then make the expiry configurable while preserving the existing seven-day behavior when no duration is supplied.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.