[Bug]: files:scan follows symlink -> endless loop
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
It is similar to https://github.com/nextcloud/server/issues/6395, but more generic, as it also happens with regular storage.
Steps to reproduce
- copy a backup from linux or Android, which contains symlinks
- e.g: include -> ../.. (/mnt/raid/gentoo/usr/include/node/deps/uv/include -> ../..)
- see that on each scan it finds more and more:
files/tobi/gentoo/usr/include/node/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/v8/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/uv/include/src/src/deps/v8/include/deps/uv/include/deps/uv/include/deps/uv/include/deps/v8/include/src/deps/v8/include/deps/v8/include/deps/uv/include/v8-profiler.h
This way I have now 44 million entries, while only ~800.000 files are on disk
Expected behavior
Do not follow symlinks, but treat them as regular files
Installation method
None
Nextcloud Server version
27
Operating system
None
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
No response
List of activated Apps
No response
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the files:scan entry point and trace how scanned filesystem entries are classified; the issue provides no file or test path. Reproduce with a symlink such as include -> ../.., then verify scanning treats the symlink as a regular file without traversing it or creating repeated entries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100