[Bug]: Inactive users are prompted to share the resource with (groupfolders)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
I found that inactive users, whome I used to share the documents earlier are still prompted to share files and folders. And in fact I am able to share the document with them by clicking mouse on the user in the drop-down list. The file is shared and it is successfully shown in the Share tab.
At the same time this user cannot be found if type in the user field.
In my opinion this is a security breach that:
- an inactive recently used user is prompted to be added to the users a document can be shared
- the document can be indeed shared with inactive users without any warning
Steps to reproduce
- have some previous interactions with some user on sharing files with him/her
- maker that user inactive
- observe that the user is still in the list of suggested users when you are going to share your file
- observe that you are able to share the document with that inactive user
Expected behavior
- Inactive users should not be prompted to be shared any files
- Inactive users should be forbidden to share with user files
Installation method
Community Web installer on a VPS or web space
Nextcloud Server version
27
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.2
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
No response
List of activated Apps
No response
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue using the listed sharing steps, focusing on groupfolders, inactive users, the suggestion drop-down, and the Share tab. Trace the relevant sharing and user-suggestion entry points; it is done when inactive users are neither suggested nor accepted for new shares, with tests covering both behaviors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100