nextcloud / nextcloud/server

[Bug]: broken recursive shares

Open
#40,788 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 27-feedback bug feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
Bug description

Due to some broken recursive shares, one can have infinite recursion causing exception when browsing the folder with the broken share and excessive memory consumption.

Steps to reproduce
  1. create an user group with at least 2 users
  2. create a group folder associated to this group FolderForGroup
  3. from one of the user in the group, create a folder inside the group folder InsideFolder
  4. share the inside folder with the user within the group (via a direct share to an user)
  5. use an user who has received the inside folder share and rename it to have those folders in its root folder (FolderForGroup and InsideFolderRenamed)
  6. move the InsideFolder within FolderForGroup in the root folder
  7. share InsideFolder to the same group that is owning the group folder
  8. try to access files from the user who created InsideFolder
Expected behavior

Share would not recurse and the user receiving a share should not be allowed to share it with the user having originally shared it

Installation method

None

Nextcloud Server version

27

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the numbered sharing sequence on Nextcloud Server 27 and capture the exception and memory growth when browsing the affected folder. Trace the share validation and recursive folder traversal involved in group-folder and direct-user shares. Done means the recursive share is rejected or safely bounded, the original sharer cannot receive the recursive share, and the reproduction no longer causes an exception or excessive memory use.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.