nextcloud / nextcloud/server

Improvements for personal info view

Open
#39,518 7 comments 0 reactions 1 assignee View on GitHub

@nimishavijay is already working on this.

Since Jul 28, 2023.

1. to develop design enhancement feature: profile
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

I would suggest to not include the labels for this PR, just remove the opacity on the buttons. My reasoning:

  • The labels don't make much sense for people who are new (for eg. "Federated" would be shown by default, which is not super easy to understand)
  • A label may also take up a lot of space, esp on mobile and for translated labels
  • Using a secondary styling will also draw a lot of attention for those elements, which are not the main focus at all. The result will be something like the screenshot attached (couldn't get the labels to work :/ ). Even if we are using tertiary button styling the button labels will be bold while the field labels will be regular weight, drawing more attention to the button.

image

Since there is a follow up issue anyway, I'd say for this a11y problem we can just change the opacity :) In the future when we change the layout of the entire page we can make sure that we use the correct components and styling :)

Originally posted by @nimishavijay in https://github.com/nextcloud/server/issues/39476#issuecomment-1643996623

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.