Provide a flag for last page in unified search
Open
Nobody has claimed this yet.
0. Needs triage
enhancement
feature: search
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Is it possible to add a server-side flag during unified search to indicate if there are no more pages? Currently we do this on client side by comparing entry count to cursor, but we have a blind spot when the entry count is the same as the cursor, in which case we don't know if this is the end.
More info here: https://github.com/nextcloud/ios/pull/2496#discussion_r1253082550
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the server-side unified search pagination path and the linked nextcloud/ios discussion. Clarify the flag's semantics for the final page, then implement and verify a response that distinguishes no-more-pages from a page whose entry count matches the cursor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, backend, search
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100