nextcloud / nextcloud/server

[Bug]: Share expiration date decreases by one day on each save

Open
#38,350 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop 25-feedback bug feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.
Bug description

I think this is a sequel to the closed bug https://github.com/nextcloud/server/issues/34926, following new date picker.

date is saved on every click but it decrease of one day
if I select 2023-05-31 it then saves 2023-05-30 you can see it actually changing after the message "expireDate has been saved"
Also it seems to occurs from desktop client 3.8.1 but not from IOS client.

Steps to reproduce

1.create a share
2.set expiredate
3.it decrease of one day on save

Expected behavior

save the date you selected

Installation method

Community Manual installation with Archive

Nextcloud Server version

25

Operating system

RHEL/CentOS

PHP engine version

PHP 7.4

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report
{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": {
            "0": "***REMOVED SENSITIVE VALUE***",
            "1": "***REMOVED SENSITIVE VALUE***",
            "2": "***REMOVED SENSITIVE VALUE***",
            "3": "***REMOVED SENSITIVE VALUE***",
            "4": "***REMOVED SENSITIVE VALUE***",
            "5": "***REMOVED SENSITIVE VALUE***",
            "10": "***REMOVED SENSITIVE VALUE***",
            "99": "***REMOVED SENSITIVE VALUE***"
        },
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "25.0.6.1",
        "overwrite.cli.url": "https:\/\/***REMOVED SENSITIVE VALUE***",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "trashbin_retention_obligation": "auto, 30",
        "versions_retention_obligation": "auto, 60",
        "app_install_overwrite": [
            "files_reader",
            "files_external_dropbox"
        ],
        "updater.release.channel": "stable",
        "filesystem_check_changes": "1",
        "htaccess.IgnoreFrontController": "true",
        "htaccess.RewriteBase": "\/",
        "skeletondirectory": "\/home\/files\/nextcloud\/skeleton",
        "mysql.utf8mb4": true,
        "default_phone_region": "ca",
        "allow_local_remote_servers": true,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "onlyoffice": {
            "jwt_secret": "***REMOVED SENSITIVE VALUE***",
            "jwt_header": "***REMOVED SENSITIVE VALUE***"
        },
        "memories.exiftool_no_local": true,
        "memories.vod.path": "\/usr\/share\/nextcloud\/apps\/memories\/exiftool-bin\/go-vod-amd64",
        "memories.gis_type": 1
    }
}
List of activated Apps
Enabled:
  - activity: 2.17.0
  - bookmarks: 12.1.0
  - bruteforcesettings: 2.5.0
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contactsinteraction: 1.6.0
  - dav: 1.24.0
  - externalpassword: 1.1.0
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.1
  - files_external: 1.17.0
  - files_inotify: 0.1.14
  - files_linkeditor: 1.1.14
  - files_mindmap: 0.0.27
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - forms: 3.2.0
  - geoblocker: 0.5.8
  - groupfolders: 13.1.3
  - libresign: 6.3.1
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - mail: 2.2.6
  - maps: 1.0.2
  - memories: 5.1.0
  - music: 1.8.3
  - nextcloud_announcements: 1.14.0
  - notifications: 2.13.1
  - oauth2: 1.13.0
  - onlyoffice: 7.8.0
  - password_policy: 1.15.0
  - photos: 2.0.1
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - recognize: 3.8.0
  - related_resources: 1.0.4
  - richdocuments: 7.1.3
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - support: 1.8.0
  - survey_client: 1.13.0
  - systemtags: 1.15.0
  - text: 3.6.0
  - theming: 2.0.1
  - twofactor_backupcodes: 1.14.0
  - twofactor_nextcloud_notification: 3.7.0
  - unsplash: 2.2.0
  - updatenotification: 1.15.0
  - user_ldap: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
Nextcloud Signing status
No errors have been found.
Nextcloud Logs
probably not related :
{"reqId":"Sw36IHGxdp0LsTHKAl6T","level":3,"time":"2023-05-17T01:03:13+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Allowed memory size of 671088640 bytes exhausted (tried to allocate 655360 bytes) at /usr/share/nextcloud/apps/recognize/lib/Clustering/MrdBallTree.php#449","userAgent":"--","version":"25.0.6.1","data":{"app":"PHP"},"id":"64644eb01df8a"}
Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report names the share expiration save flow and the new date picker, but no repository file or test. First reproduce with Nextcloud Server 25 and desktop client 3.8.1, then trace the request that saves the expiration date and compare the selected value with the persisted value; done when repeated saves retain the selected date and a regression test covers it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
api, backend, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.