Add new rules operator OR
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Expected behaviour
It would be nice to be able to use a new rule operator such as OR
Actual behaviour
The only rules operator is AND which strongly limits the possibilities.
For example, in the case of a folder which you would want accessible by people in two different groups in now impossible. Whereas it would be great if you could set it like:
When the file is read:
and collaborative tag is XXX
and (user is member of group YYY OR user is member of group ZZZ)
This would solve a lot of use cases for subfolder access control
(https://github.com/nextcloud/server/issues/6050)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing rules operator implementation and the tests covering the current AND-only behavior. Trace how folder access conditions are evaluated, then define and test the expected behavior for combining group membership with OR, including the linked subfolder access-control use case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authorization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100