nextcloud / nextcloud/server

Maintenance mode does not invalidate OPcache

Open
#37,557 4 comments 0 reactions 1 assignee View on GitHub

@joshtrichards is already working on this.

Since Sep 16, 2024.

2. developing 25-feedback bug feature: caching feature: install and update pending documentation
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

⚠️ This issue respects the following points: ⚠️
  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.
Bug description

When the maintenance mode gets activated, Nextcloud does not invalidate the OPcache of php. Hence, if the option opcache.validate_timestamps is set to 0, as advised by the official Server tuning manual, the web interface will continue to to be served, instead of the maintenance page.

Steps to reproduce
  1. Set the option opcache.validate_timestamps to 0 via the php configuration
  2. Start or restart the php interpreter (OPcache is populated)
  3. Open the webinterface and log in via any user
  4. Enable the maintenance mode via OCC command or perform a maintenance task, that automatically enables it
  5. Go back to the web interface and navigate around (everything will act like normal, but changes to the DB will of course fail)
Expected behavior

As the software does with changes to the configuration or other php files, enabling the maintenance mode should also invalidate the respective cached code, so the maintenance page is served to the user, the next time he loads a web interface page.

Installation method

Community Docker image

Nextcloud Server version

25

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Nginx

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report
{
	"system": {
		"simpleSignUpLink.shown": false,
		"memcache.local": "\\OC\\Memcache\\APCu",
		"apps_paths": [{
				"path": "\/var\/www\/html\/apps",
				"url": "\/apps",
				"writable": false
			},
			{
				"path": "\/var\/www\/html\/custom_apps",
				"url": "\/custom_apps",
				"writable": true
			}
		],
		"loglevel": 2,
		"passwordsalt": "***REMOVED SENSITIVE VALUE***",
		"secret": "***REMOVED SENSITIVE VALUE***",
		"trusted_domains": [
			"***REMOVED SENSITIVE VALUE***"
		],
		"datadirectory": "***REMOVED SENSITIVE VALUE***",
		"dbtype": "mysql",
		"version": "24.0.4.1",
		"dbname": "***REMOVED SENSITIVE VALUE***",
		"dbhost": "***REMOVED SENSITIVE VALUE***",
		"dbport": "",
		"dbtableprefix": "oc_",
		"mysql.utf8mb4": true,
		"dbuser": "***REMOVED SENSITIVE VALUE***",
		"dbpassword": "***REMOVED SENSITIVE VALUE***",
		"installed": true,
		"instanceid": "***REMOVED SENSITIVE VALUE***",
		"default_language": "de",
		"default_locale": "de",
		"default_phone_region": "DE",
		"mail_smtpmode": "smtp",
		"mail_smtpauthtype": "LOGIN",
		"mail_smtphost": "***REMOVED SENSITIVE VALUE***",
		"mail_from_address": "***REMOVED SENSITIVE VALUE***",
		"mail_domain": "***REMOVED SENSITIVE VALUE***",
		"templatedirectory": "\/var\/www\/html\/core\/skeleton\/Templates\/",
		"enabledPreviewProviders": [
			"OC\\Preview\\PNG",
			"OC\\Preview\\JPEG",
			"OC\\Preview\\GIF",
			"OC\\Preview\\BMP",
			"OC\\Preview\\XBitmap",
			"OC\\Preview\\MP3",
			"OC\\Preview\\TXT",
			"OC\\Preview\\MarkDown",
			"OC\\Preview\\OpenDocument",
			"OC\\Preview\\Krita",
			"OC\\Preview\\HEIC"
		],
		"redis": {
			"host": "***REMOVED SENSITIVE VALUE***",
			"port": "6379",
			"timeout": "1.5",
			"dbindex": "0"
		},
		"memcache.locking": "\\OC\\Memcache\\Redis",
		"memcache.distributed": "\\OC\\Memcache\\Redis"
	}
}
List of activated Apps
Enabled:
  - accessibility: 1.10.0
  - activity: 2.16.0
  - circles: 24.0.1
  - cloud_federation_api: 1.7.0
  - comments: 1.14.0
  - contactsinteraction: 1.5.0
  - dashboard: 7.4.0
  - dav: 1.22.0
  - federatedfilesharing: 1.14.0
  - federation: 1.14.0
  - files: 1.19.0
  - files_pdfviewer: 2.5.0
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - files_videoplayer: 1.13.0
  - firstrunwizard: 2.13.0
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - nextcloud_announcements: 1.13.0
  - notifications: 2.12.0
  - notify_push: 0.4.0
  - oauth2: 1.12.0
  - password_policy: 1.14.0
  - photos: 1.6.0
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - recommendations: 1.3.0
  - serverinfo: 1.14.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - support: 1.7.0
  - survey_client: 1.12.0
  - systemtags: 1.14.0
  - text: 3.5.1
  - twofactor_backupcodes: 1.13.0
  - updatenotification: 1.14.0
  - user_status: 1.4.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflowengine: 2.6.0
Disabled:
  - admin_audit
  - encryption
  - files_external
  - theming: 1.15.0
Nextcloud Signing status
No errors have been found.
Nextcloud Logs

No response

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.