tests/unit/CalDAV/CalDavBackendTest.php:1278 is flacky
Open
Nobody has claimed this yet.
1. to develop
feature: caldav
feature: dav
papercut
technical debt
tests
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
One issue reported with Postgres and CalDAV resulting in different payload. Related?
No, the used API does not sort and just assumes results are sorted by ID.
So flaky by design and we should fix it (in another PR) by:
- Sorting the data before returning
- Sorting the result in the test
- Compare in a way that sort order does not matter
Originally posted by @nickvergessen in https://github.com/nextcloud/server/issues/37306#issuecomment-1477430743
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/unit/CalDAV/CalDavBackendTest.php at line 1278 and inspect the CalDAV result comparison. Run the test with PostgreSQL to reproduce the differing payload, then make the test or returned data independent of result order. Done means the test passes consistently regardless of ordering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, postgresql
- Domain
- backend, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100