Support to dark theme at unified search component
@provokateurin is already working on this.
Since Aug 24, 2024.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
When we use the component UnifiedSearch, this component use the query string ?term=test&from=/<pathOfCurrentPage> and the backend can't identify if is using dark theme or not to backend provide as response the thumbnailUrl with or without dark theme applied.
Describe the solution you'd like
Send the query parameter theme=dark when the user is using dark theme to make possible all search providers return the right image. And also add the theme as an optional parameter to UnifiedSearchController#search method.
An effect related with this suggestion of solution is that all search providers will need to consider this search parameter if need to have dark theme support.
Additional context
Actual behavior:
Expected behavior:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.