nextcloud / nextcloud/server

Create typed events for all remaining hooks used by admin_audit

Open
#37,194 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop feature: admin audit technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

As part of #14552.

The admin audit app uses a lot of hooks due to it's nature. A first part has been removed in #37193. I'm listing the rest of them here to track replacements.

See also https://github.com/nextcloud/server/issues/32128

LDAP

  • \OC\User assignedUserId (part of #14552 thanks to #32019)
  • \OC\User postUnassignedUserId (part of #14552 thanks to #32019)

Shares

  • OCP\Share post_update_permissions
  • OCP\Share post_update_password
  • OCP\Share post_set_expiration_date
  • OCP\Share share_link_access

Files

  • Filesystem::CLASSNAME Filesystem::signal_post_rename
  • Filesystem::CLASSNAME Filesystem::signal_post_create
  • Filesystem::CLASSNAME Filesystem::signal_post_copy
  • Filesystem::CLASSNAME Filesystem::signal_post_write
  • Filesystem::CLASSNAME Filesystem::signal_post_update
  • Filesystem::CLASSNAME Filesystem::signal_read
  • Filesystem::CLASSNAME Filesystem::signal_delete

Versions

  • \OCP\Versions rollback
  • \OCP\Versions delete

Trashbin

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the remaining hook list in this issue and the related issues #14552, #32128, and pull request #32018. Trace the admin_audit uses of the listed Share, Filesystem, Versions, and Trashbin hooks, then verify that each has a typed-event replacement and is no longer dependent on the legacy hook.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.