Add files pattern to ignore EXTRA_FILE checker errors
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
The code signing feature is a valuable one. However, to increase performance of my personal server, I use the combination of brotli_static on; in nginx, and pre-generate all brotli files (using static-compress). Thus it creates a bunch of .br files in the directory.
Describe the solution you'd like
I'd like a setting to describe which files I know for sure are EXTRA_FILEs. Ideally, this would be a regexp, so that I could ignore all .br files.
Describe alternatives you've considered
- Disabling
brotli_static on;. Files are recompressed on each new request. My server is not powerful, so I'd like to avoid that. - Serve static files from outside code signing root, but it's a heavy gymnastic on each upgrade.
Additional context
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked code-signing documentation and locate the EXTRA_FILE checker in the Nextcloud server code. Determine how a configurable file pattern could be represented and applied safely, then verify that matching .br files are ignored while unrelated unexpected files remain reported. The payload names no implementation files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx, php
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100