nextcloud / nextcloud/server

Enable usage of svg favicons and remove imagick from iconbuilder

Open
#36,607 11 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop feature: theming help wanted technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.

Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons

cc @juliushaertl

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the theming app's iconbuilder and favicon-generation entry points first, then inspect how imagick is required and how favicon formats are selected. Review the linked favicon reference and verify that SVG favicons work while other image tasks remain supported without imagick; done means the dependency is no longer enforced and SVG favicons are enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.