When using share by mail with password, don't allow disabling emailing passwords
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Information
When enabling the share by mail app with the option send passwords, it is currently possible to untick the checkbox "Send password by mail".
The feature in question does require being able to send passwords by mail, so we should grey out the latter option and force-enable it in the described scenario.
See https://github.com/nextcloud/server/issues/31005#issuecomment-1222268651 for more context
@StCyr
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the context in issue #31005, then locate the share-by-mail password options in the Nextcloud server code. Verify the behavior when the share-by-mail app requires emailed passwords: the “Send password by mail” checkbox should be greyed out and remain enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100