Remove getPublicCalendars in CalDAVBackend.php
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
In fact we do not call getPublicCalendars anymore since https://github.com/nextcloud/server/pull/4224 and this method is only used in tests, so we don't really need to change it.
Well as it's still being used in the tests we can refactor them then remove it directly altogether. Even though the method is public it's kind of a private API, and I don't seem to find anywhere it's been used anyway.
Originally posted by @tcitworld in https://github.com/nextcloud/server/pull/34372#discussion_r985243237
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in CalDAVBackend.php by locating getPublicCalendars and then search the repository for its test usages. Refactor those tests away from the method, remove the unused method, and run the affected test suite to confirm there are no remaining references and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100