Users in groups excluded from sharing can initiate shares if also a member of a non-excluded group
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
Steps to reproduce
- Create a "No sharing" group
- Add a user to "No sharing" group
- Configure to not allow "No sharing" group to initiate shares
- Share folder with another user
Expected behaviour
The user shouldn't be able to initiate a share
Actual behaviour
The user initiate a share successfully that can be seen and modified by target user
Server configuration
Operating system:
Shared host
Web server:
Apache
Database:
MySQL 5.6.34
PHP version:
7.0.15
Nextcloud version: (see Nextcloud admin page)
11.0.0
Updated from an older Nextcloud/ownCloud or fresh install:
Fresh
Where did you install Nextcloud from:
Unarchive archive file downloaded from nextcloud site
Signing status:
Signing status
No errors have been found.
List of activated apps:
App list
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder
The content of config/config.php:
Config report
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder
or
Insert your config.php content here
(Without the database password, passwordsalt and secret)
Are you using external storage, if yes which one: no
Are you using encryption: no
Are you using an external user-backend, if yes which one: no
Client configuration
Browser: Chrome 56
Operating system: Any
Logs
Web server error log
Web server error log
``` Error index Error: Call to undefined function OCA\Theming\mime_content_type() ```Nextcloud log (data/nextcloud.log)
Nextcloud log
``` Insert your Nextcloud log here ```Browser log
Browser log
``` Insert your browser log here, this could for example include:a) The javascript console log
b) The network log
c) ...
</details>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the group-sharing configuration described in the issue on a Nextcloud server, focusing on the permission check for users who belong to both excluded and non-excluded groups. Confirm that a user in an excluded group cannot initiate a share, while preserving expected sharing for permitted users; the issue names no files or tests, so locating the relevant sharing authorization code will require repository research.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100