nextcloud / nextcloud/server

Updater Stability on Network Errors

Open
#33,561 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: apps management feature: install and update technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently, the CLI updater does not check the availability of the app store (apps.nextcloud.com) before starting the upgrade. The occ upgrade command also does not check this, and it does not seem to display an error message when trying to upgrading apps.
With apps.nextcloud.com having been down right now, I just upgraded my Nextcloud from 23 to 24.0.4, and I ended up with half my apps disabled due to being incompatible. There was no indication of any error whatsoever. And I now need to wait for the app store to be available again before my users can use the nextcloud as usual.

Describe the solution you'd like

  • Add error messages to the occ upgrade command when it cannot reach the app respository. Also show an error in the Nextcloud Apps UI when the repository is unavailable. Update successful is also a pretty misleading statement in case of the repository being unreachable, this should be changed to something appropriate (e.g., "app upgrade routines successful, but not all apps could be downloaded properly").
  • Check availability of external resources before starting the nextcloud upgrade (right before the fist change to the system has been made)
  • The best would be to even download all required resources (like app upgrades) before making any changes to the server at all, so the process can be cancelled if the repository becomes unavailable during the process.
  • If users are located behind a firewall or otherwise need to be able to work without the repository, there should be a configuration option or CLI arguments to continue the process in case of unavailability.

Describe alternatives you've considered
There aren't really alternatives - each task in the list above can stand on its own and will improve this. I could check this manually, but I think that I should not be required to know what to check for, and I should trust the updater to have adequate checks in place.

Additional context
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the occ upgrade command and the CLI updater, then trace the corresponding Nextcloud Apps UI handling for apps.nextcloud.com failures. Define the expected error and success states for unavailable repositories, including checks before changes and behavior when downloads fail; no specific files or tests are named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, cli, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.