Color variables for success and warning lack contrast
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
The color values for both --color-success and --color-warning lack contrast for even large text AA and graphical objects & interface components – meaning we should not use them anywhere.
Darkening them a bit would make them usable at least for those 2 cases. What do you think @juliushaertl @skjnldsv @marcoambrosini @juliakirschenheuter?
| color-success | color-success darkened |
|---|---|
 |
 |
| color-warning | color-warning darkened (probably needs adjustment, dark orange always looks a bit bad ;) |
|---|---|
 |
 |
color-error works well
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the definitions and usages of --color-success and --color-warning in the repository, then review the reported contrast examples and the existing --color-error value. Done means both variables are darkened enough to meet contrast for large text AA and graphical objects or interface components, with the warning color still visually acceptable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- accessibility, design, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100