Send file path to imaginary
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
#24166 introduced imaginary as a preview provider.
optional perf improvement: if we know a file to be on local non-encrypted storage, could send the file path directly to the docker (when running on same instance)
This was also said as an optional requirement. This could indeed offload even more load from the nextcloud php part (not only on the same machine). In a docker/k8s cluster imaginary could load the image directly from the storage backend (s3, nfs, ...). The machine running the web server (php) wouldn't be occupied as much. Also this would relief quite some load from the network infrastructure and is especially notable when using imaginary for RAW images which can be 25MB per file being sent around for no good reason.
Describe the solution you'd like
Send the file path to imaginary to gain some performance.
This could be in an optional config option. I think auto detecting stuff (as described in the original quote) is out of the scope and any admin can decide on their own how this would affect the deployment.
Describe alternatives you've considered
N/A
Additional context
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the imaginary preview provider introduced in #24166 and review its current file-handling flow. Check how an optional configuration could provide a file path, and consider the deployment implications described for local storage and Docker/Kubernetes; done means the opt-in path is supported without changing the default behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, performance
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100