nextcloud / nextcloud/server

Add phone region code in install wizard

Open
#32,613 0 comments 18 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: install and update papercut
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

default_phone_region is in the sample config. It says there is no defaults. So I removed it.

Sanity check reported it with a Warning:

Your installation has no default phone region set. This is required to validate phone numbers in the profile settings without a country code. To allow numbers without a country code, please add "default_phone_region" with the respective [ISO 3166-1 code ↗](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#Officially_assigned_code_elements) of the region to your config file.

So we can't get the green check mark without the setting applied.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Since it raises a warning, but it can't have a default value (at least the sample told), it deserves a text field in the installation wizard,
with the same link to the wikipdia page

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Define a default value, but it seems rejected from the comment in the sample config file
  • Have a drop-down with the table code, but it seems there is no webservice available for this.

Additional context
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the installation wizard and the configuration handling for default_phone_region. Review how the wizard collects settings and how the sanity check reports a missing phone region; done means the wizard offers the region code field with the linked ISO 3166-1 reference and the resulting installation passes the check.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.