Sharing (user search) options are confusing / misleading
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
The options
'Allow username autocompletion to users based on phone number integration'
and
'Allow username autocompletion when entering the full name or email address'
seem to do somehow the opposite of the description in that they restrict the user search and don't 'allow' for something.
The for labels name the restriction as such.
<label for="shareapi_restrict_user_enumeration_to_phone">
<label for="shareapi_restrict_user_enumeration_full_match">
So I propose a change of the descriptions to reflect the restrictions of these settings, for exampie 'Allow only...'
The issue recently caused major confusion and it would be much appreciated if this could be changed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open apps/settings/templates/settings/admin/sharing.php and locate the settings associated with shareapi_restrict_user_enumeration_to_phone and shareapi_restrict_user_enumeration_full_match. Review the current labels and descriptions, then update the wording so it clearly describes the restriction. Done means both options no longer imply that they broaden user search.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- frontend
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100