Template folder should use the file id
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
As per comment in https://github.com/nextcloud/server/pull/28645#issuecomment-1056526796 the template folder should be stored using the file id of the folder instead of the path of a user which has the benefit that it would survive the rename or move of the folder itself.
I'd suggest to do a rolling upgrade of that part so that if we detect a path in the config, we switch it to the file id directly and continue to use that further on.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked comment on pull request #28645 and tracing where the template-folder path is read from configuration and resolved to a folder. Done means a path is converted during a rolling upgrade to the folder's file ID, and later renames or moves continue to identify the same folder.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100