nextcloud / nextcloud/server

`\OCA\DAV\DAV\CustomPropertiesBackend` should use the query builder or a QBMapper

Open
#30,389 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop feature: caldav feature: carddav feature: dav technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Is your feature request related to a problem? Please describe.

The class \OCA\DAV\DAV\CustomPropertiesBackend builds manual SQLs for the most part.

Describe the solution you'd like

Migrate to the query builder or even offload the storage aspects to a dedicated QBMapper.

Describe alternatives you've considered

n/a

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with apps/dav/lib/DAV/CustomPropertiesBackend.php and identify the manual SQL operations used for custom-property storage. Review the query builder and QBMapper options in the surrounding code, then migrate those storage operations and verify the existing DAV custom-property behavior with the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, sql
Domain
backend, database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.