nextcloud / nextcloud/server

Show device type icon for clients

Open
#30,186 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage client: 💻 desktop client: 🤖🍏 mobile enhancement feature: authentication feature: settings
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

During weblogin we send a custom user agent (containing manufacteur, device name), but this does not match
https://github.com/nextcloud/server/blob/master/apps/settings/src/components/AuthToken.vue#L109-L110

and thus the icons are not shown.
At least Desktop, mobile should have an icon.
(we could also think about more specific, e.g. Android Talk/Files, iOS Talk/Files, etc, but for first approach Desktop/mobile should be ok.

Currently, as far as I know, the sent UA from weblogin flow is just directly used.
To not interfere with above (https://github.com/nextcloud/server/blob/master/apps/settings/src/components/AuthToken.vue#L109-L110) I suggest that we add logic that passed UA on weblogin sends an unique device type, .eg:
"Oneplus ONEPLUS A6013 (Android) ANDROID_FILES"
"tobi-desktop (Desktop Client - Linux) DESKTOP_LINUX"

and that those strings are then filtered out and used as type.

"Roadmap" would be to put it on board on server, then agree on work flow and then Talk and Clients can implement it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the matching logic around lines 109-110 of apps/settings/src/components/AuthToken.vue and inspect how the weblogin user agent is currently passed through. Determine how Desktop and mobile device types should be identified without breaking existing user agents, then verify that the corresponding icons appear in the authentication-token list.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
authentication, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.