nextcloud / nextcloud/server

Refactor reminder back-end to use a QB mapper

Open
#30,166 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop feature: caldav feature: dav technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

The CalDAV reminder back-end uses the raw query builder to insert/update/delete rows, has it's own column casting logic and so on.

Describe the solution you'd like

This could be moved to a simple QB mapper that takes care of this out of the box. Plus, we gain some type safety in that service.

Describe alternatives you've considered

N/a

Additional context

N/a

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CalDAV reminder back-end service and reading its raw query-builder insert, update, and delete paths, including the existing column-casting logic. Compare the current behavior before moving these operations into a QB mapper; done means the service uses the mapper, preserves reminder persistence behavior, and gains the intended type safety.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.