Enforce `hide_login_form` server-side
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
As far as I can tell, the hide_login_form config parameter is purely cosmetic. It hides the login form, but doesn't disable it on the server.
Describe the solution you'd like
Either enforce hide_login_form on the server, or add a new config parameter to do that.
Describe alternatives you've considered
Locking the passwords of all users (similar to using a crypted hash of ! in /etc/shadow) would work too, but I don't see a way to lock a password, only to change it.
Additional context
I used to use password+U2F to log in, but I'm trying to switch to the oidc_login plugin. I don't want to leave additional login mechanisms around after switching.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the server-side handling of the hide_login_form configuration and the existing password-login tests. Done should mean that enabling the setting prevents the unwanted login mechanism server-side, with coverage for the configuration behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100