OC_Defaults and ThemingDefaults
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
When getting OC_Defaults with DI we ask the Server to give use the ThemingDefaults but in some weird cases, we get OC_Defaults instead. Problem is that OC_Defaults can be quite buggy and the unexpected behavior of the container returning an OC_Defaults instead of a ThemingDefauls can be hard to debug.
We should probably port everything using OC_Defaults to ThemingDefaults so that we can get rid of OC_Defaults and not get some weird DI bugs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the server codebase for OC_Defaults, ThemingDefaults, and their dependency-injection entry points. Identify every OC_Defaults use and assess the affected callers before migrating them; done means those uses consistently receive ThemingDefaults and OC_Defaults can be removed without the reported container confusion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100