Migrate `\OC\User::assignedUserId` to `EventDispatcher` and execute in the background
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
- The event (and
preUnassignedUserIdandpostUnassignedUserId) is not migrated to EventDispatcher yet - user_ldap should dispatch it as background job
- guests should then use EventDispatcher, too
- check other apps?
Background for 2) because the event is emitted early while the user is not fully processed yet, it lead's to at least one additional ldap_read operation/user. This can be saved when doing it afterwards as the display name will be cached by then. This might save some DB requests. It should be clarified whether there are any conflicts with IUsers::triggerChange(), which will also happen during user update (but slightly later).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace OC\User::assignedUserId and the preUnassignedUserId/postUnassignedUserId events, then inspect the user_ldap and guests integrations around EventDispatcher. Clarify the interaction with IUsers::triggerChange() before changing behavior. Done means the listed event migrations, background dispatch for user_ldap, EventDispatcher use by guests, and checks of other apps are complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication, backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100