Handle 403 by ToS better
Open
Nobody has claimed this yet.
client: 💻 desktop
client: 🤖🍏 mobile
overview
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
- Android @tobiasKaminsky
- Desktop @nextcloud/desktop
- iOS @marinofaggiana
Steps to test:
- log in on client
- install latest master of ToS on master server
- uncomment https://github.com/nextcloud/terms_of_service/blob/master/lib/AppInfo/Application.php#L78-L89
- revoke signatures in settings
- see different behaviour
- Android: does nothing
- iOS: ask for re-authenticate
- Desktop: shows only in settings a read error
--> all should show in a direct way an error so that user knows what is going on
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the listed flow against the latest master versions of ToS and the server, including uncommenting ToS lib/AppInfo/Application.php lines 78-89 and revoking signatures. Compare the Android, iOS, and Desktop behavior for the resulting 403. Done means each client directly shows an understandable error explaining what the user must do.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, ios, php
- Domain
- api, authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100