nextcloud / nextcloud/server

Add annotation to limit body size of incoming requests

Open
#26,565 2 comments 0 reactions 1 assignee View on GitHub

@LukasReschke is already working on this.

Since May 25, 2021.

1. to develop enhancement security
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

As suggested by @blizzz, we should consider adding an annotation to the AppFramework that limits the incoming body size. This can help in cases where we could accidentally store too much data in the database.

The annotation could by default be set to a reasonably high limit such as 1MB, and the limit should be overwritable by developers. (or even completely disabled)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.