nextcloud / nextcloud/server

Don't upgrade while background jobs are currently being executed

Open
#24,777 3 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop feature: install and update high technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

The updater needs to check that no background job is reserved at the moment. (maybe it could even reserve them all?)
Happened on c.nc.c and purged all rooms because attendees where currently being migrated but all rooms with out attendees where deleted in parallel with the background job that was started ~6 minutes before and didn't finish nor stop to take new tasks while the upgrade was running in parallel.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the updater and the background-job reservation flow described in the issue, focusing on how an upgrade runs while a job is still executing. Check existing tests around upgrades and background jobs if available. Done means an upgrade cannot proceed while reserved work is active, preventing concurrent migration and cleanup from deleting rooms.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.