nextcloud / nextcloud/server

Show email address for shares that were created by other users

Open
#24,655 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

client: 💻 desktop client: 🤖🍏 mobile feature: sharing overview
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Steps to reproduce:

  • Share a file as user0 with user1
  • As user1 share the file via email to foobar@example.com
  • As user0 try to share the file to foobar@example.com

The main issue here is that the share list doesn't clearly indicate that the file was already shared with that email address, only that it was shared with a link by user1.

Before:
share-email-old

After:
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue provides reproduction steps and a platform checklist, and the server-side work is already in pull request 24635. Start by reviewing that pull request and the remaining Android, Desktop, and iOS share-list implementations. Done means the share list clearly shows the email address when the file was already shared with it.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, ios, php
Domain
backend, desktop, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.