nextcloud / nextcloud/server

File deletion timespan in trash should be rounded down

Open
#24,266 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop design enhancement feature: files feature: trashbin
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

describtion
The files app shows in the trash folder at the right side the timespan since this file was deleted. This timespan is translated to a human readable format like "a year ago". But in the tooltip I see (today) a day in 2020.
grafik
Note: The screenshot was taken in 2020/11/20

solution I would like
Specially (or only?) for the trash I mean it is more intuitive, that the "was deleted time" is at least the timespan. If is displayed "a year ago" I sense the deletion is at least one year old. Not the deletion is rounded one year old.

notes
I think this could prevent a to early permanent deletion of a file.
May be this is also more intuitive for "modified at" timespans.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named in the issue. Start by reproducing the trash view and its deletion-age tooltip, then trace where that displayed timespan is calculated; done means the trash age is rounded down consistently, with coverage for the reported 2020 example.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.