nextcloud / nextcloud/server

Removing a public link shows wrong user in activities

Open
#23,359 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage 25-feedback bug feature: activity and notification feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

I (User A) removed a public link that was created by another user (User B), the activity feed says "<User B> removed public link for <filename>" but it should say User A instead.

Steps to reproduce:

  1. Log in as <User A> and create a file
  2. Share that file with <User B> internally (not via public link)
  3. Log in as <User B> and create a public share link for the file
  4. The activity feed now shows "<User B> shared <filename> as public link"
    image
  5. Log in as <User A> and unshare the public link created by <User B>

Expected behavior:
The activity feed should show "<User A> removed public link for <filename>"

Actual behavior:
The activity feed shows "<User B> removed public link for <filename>"
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the public-link removal flow using the five steps in the issue, then trace the activity-feed handling for removing a public link. Done means the feed attributes removal to User A, the user who unshared the link, rather than User B, who created it.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.