nextcloud / nextcloud/server

Option to disable showing system email in avatars' contacts menu

Open
#23,172 2 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: contacts menu good first issue privacy
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

Steps
  1. Setup a NC instance
  2. Create accounts for many external people with email so they can receive an invitation and notifications
  3. Create a Talk conversation with all people
  4. Click on the three dots on a person's avatar in the participant list
Expected result

In the case of external people, we should not see their email address.

Actual result

There's an option to see and click an email address

I suggest to add an option to remove the EmailProvider in config.php or other.
A quick hack is to remove https://github.com/nextcloud/server/blob/stable20/lib/private/Contacts/ContactsMenu/ActionProviderStore.php#L88 in config.php

Version

Nextcloud 20

@rullzer @ChristophWurst FYI

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/private/Contacts/ContactsMenu/ActionProviderStore.php, especially the EmailProvider reference mentioned in the issue, and inspect how config.php options are handled. Define the configuration behavior so the email action can be disabled for external contacts, then verify that the contacts menu no longer exposes their email address when disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.