nextcloud / nextcloud/server

Accept shares, show pending shares on top of view

Open
#2,192 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop client: 💻 desktop client: 🤖🍏 mobile enhancement feature: sharing high overview
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

The pending shares should show on top of the files view, without the need for yet another sidebar entry.
Incoming should be at the top, and rejected ones sorted at the bottom and greyed out. That way you can also get rejected shares back.

For incoming shares you can accept or reject them, and for rejected shares you can re-accept (undo rejection) or permanently delete. (Otherwise you’re stuck with a »pending shares« section for longer than you want.)

cc @nickvergessen @schiessle

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the files view and its existing share actions, then inspect how pending, incoming, and rejected shares are represented. Implement the requested ordering, visual treatment, and actions for accepting, rejecting, undoing rejection, and permanent deletion. Done means all four states are available from the files view without a separate sidebar entry.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
cloud, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.