Warn if apps still use `View` (rather than `Node`)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 36.9k
- Forks
- 5.2k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 713
Description
See discussion in https://github.com/nextcloud/server/pull/1233
Apps should not use private classes. We should start warning in the code checker and maybe even the logs. Apps should use the Node API. And if stuff is missing from there we should invest time in adding that functionality.
The node API was introduced ~3 years ago. So I'd say apps should migrate ASAP!
CC: @icewind1991 @nickvergessen
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion in pull request 1233 and trace how the code checker identifies apps using the private View class. Review the relevant logging path if warnings should also appear there. Done means apps using View receive a warning and the Node API is identified as the replacement.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, backend, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100