nextcloud / nextcloud/server

"Shared by" user is not the one expected in nested shares

Open
#19,860 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: sharing
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

It is related to https://github.com/nextcloud/server/pull/6094

Steps to reproduce
  1. Bob shares a folder A with Alice
  2. Alice creates a folder B inside A and shares it with Max
Expected behaviour

Max should see "Shared by Alice" in the folder B info

Actual behaviour

Max sees "Shared by Bob" in the folder B info

Well it actually created problems for me :

I am Alice, my associate Bob created a "master" shared folder for everything happening in our company. I created a sub-folder shared with my client, Max, that does not know Bob...
And Max is complaining : "Who the hell is this Bob that shares stuff with me ?!"

Server configuration

Operating system: Debian Stable

Web server: Apache

Database: mysql Version : 10.3.22

PHP version: 7.3.14

Nextcloud version: 18.0.1

Updated from an older Nextcloud/ownCloud or fresh install: Fresh

Where did you install Nextcloud from: Not sure, Debian packages I think

Signing status:

Signing status
Login as admin user into your Nextcloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results here.

No errors have been found.

List of activated apps:

App list Not relevant here ``` If you have access to your command line run e.g.: sudo -u www-data php occ app:list from within your Nextcloud installation folder ```

Nextcloud configuration:

Config report Not relevant here ``` If you have access to your command line run e.g.: sudo -u www-data php occ config:list system from within your Nextcloud installation folder

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the nested-share steps described in the issue and compare the folder B info shown to Max with the expected sharer. The fix is complete when Max sees "Shared by Alice" rather than "Shared by Bob" for the nested share, with coverage for this scenario.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.