nextcloud / nextcloud/server

ShareQuery

Open
#19,239 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: sharing technical debt
Dominant language
PHP
Stars
36.9k
Forks
5.2k
Avg merge
2d 3h
Merged PRs (30d)
713

Description

From time to time I come across needing specific shares. Which we don't have a function for to get.

What I think would be good is to introduce something like a sharequery. So we can query the sharemanager for this sharequery.

You could set things like

  • sharetype
  • fileid
  • expiration before
  • expiration after
  • owner
  • initiator
  • recipient
    ...

Then we could solve a lot of things by a generic function. Instead of this never ending list of dedicated functions.

cc: @ChristophWurst @nickvergessen @juliushaertl @icewind1991

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating ShareManager and reviewing the existing dedicated share lookup functions, since the issue names no files or tests. Compare the requested filters—share type, file ID, expiration, owner, initiator, and recipient—and define what a generic ShareQuery must support before implementation. Done means ShareManager can query shares through this mechanism instead of requiring a growing list of dedicated functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.